Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

refactor: Rename data to event #2357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2019
Merged

refactor: Rename data to event #2357

merged 1 commit into from
Sep 4, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Aug 23, 2019

Consistently use the term event for events:
b/139649933

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2019
@grant grant requested a review from ace-n August 23, 2019 00:06
ace-n
ace-n approved these changes Aug 23, 2019
View reviewed changes
Copy link

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if @stew-r approves.

(IIRC he had thoughts on this; can't remember what they were.)

@stew-r
Copy link
Contributor

stew-r commented Aug 28, 2019

LGTM

@grant grant merged commit 6452e74 into master Sep 4, 2019
@grant grant deleted the grant-139649933 branch September 4, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grant @stew-r @ace-n @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.