Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Python Text-to-Speech "Speaking addresses with SSML" tutorial #2255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 55 commits into from
Jul 11, 2019
Merged

Python Text-to-Speech "Speaking addresses with SSML" tutorial #2255

merged 55 commits into from
Jul 11, 2019

Conversation

crowdus
Copy link
Contributor

@crowdus crowdus commented Jul 3, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 3, 2019
@beccasaurus beccasaurus requested a review from nnegrey July 3, 2019 21:49
@nnegrey
Copy link
Contributor

nnegrey commented Jul 8, 2019

@ecrowdus, are these ready for review?

@crowdus
Copy link
Contributor Author

crowdus commented Jul 8, 2019

@nnegrey yes, they are--thanks.

nnegrey
nnegrey suggested changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Just some comments on our general formatting / style. :) 👍

texttospeech/ssml_addresses/README.md Outdated Show resolved Hide resolved
texttospeech/ssml_addresses/README.md Outdated Show resolved Hide resolved
texttospeech/ssml_addresses/tests.py Outdated Show resolved Hide resolved
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
texttospeech/ssml_addresses/tests.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 9, 2019
View reviewed changes
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 9, 2019
View reviewed changes
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts_test.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts_test.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts_test.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts_test.py Outdated Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 10, 2019
View reviewed changes
texttospeech/ssml_addresses/tts_test.py Show resolved Hide resolved
nnegrey
nnegrey reviewed Jul 11, 2019
View reviewed changes
texttospeech/ssml_addresses/tts.py Outdated Show resolved Hide resolved
nnegrey
nnegrey approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@nnegrey nnegrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nnegrey nnegrey merged commit 696a1cf into GoogleCloudPlatform:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnegrey nnegrey nnegrey approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crowdus @nnegrey @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.