Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update delete_full_collection sample to use batch_size as the limit #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

Update delete_full_collection sample to use batch_size as the limit #2216

merged 1 commit into from
Jul 22, 2019

Conversation

BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Jun 12, 2019 •
edited
Loading

Fixes #2170

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2019
gguuss
gguuss approved these changes Jul 17, 2019
View reviewed changes
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want me to merge this for you.

@LouisTrezzini LouisTrezzini mentioned this pull request Jul 22, 2019
Closed
@BenWhitehead BenWhitehead merged commit 2392042 into GoogleCloudPlatform:master Jul 22, 2019
@BenWhitehead BenWhitehead deleted the fix-2170 branch July 22, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@gguuss gguuss gguuss approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in firestore delete-data sample
5 participants
@BenWhitehead @theacodes @gguuss @kurtisvg @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.