feat(storage): Add snippets for v4 signed URLs #2142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankyn
suggested changes
May 8, 2019
storage/cloud-client/snippets.py
Outdated
| print("curl -X PUT -H 'Content-Type: application/octet-stream' " | ||
| "--upload-file my-file \'{}\''.format(url)") | ||
| return url | ||
| # [END storage_generate_signed_url_v4] |
There was a problem hiding this comment.
Nit: storage_generate_upload_signed_url_v4
| @@ -350,6 +406,14 @@ def copy_blob(bucket_name, blob_name, new_bucket_name, new_blob_name): | ||
| 'signed-url', help=generate_signed_url.__doc__) | ||
| signed_url_parser.add_argument('blob_name') | ||
|
|
||
| signed_url_download_v4_parser = subparsers.add_parser( |
There was a problem hiding this comment.
Calling the generate signed URL should be added to the switch statement below.
storage/cloud-client/snippets.py
Outdated
| print(url) | ||
| print('You can use this URL with any user agent, for example:') | ||
| print("curl -X PUT -H 'Content-Type: application/octet-stream' " | ||
| "--upload-file my-file \'{}\''.format(url)") |
There was a problem hiding this comment.
I think this line will have issues with format() as it's part of the double quoted string.
|
not sure how to fix this.. |
|
Reading more on it here: https://lintlyci.github.io/Flake8Rules/rules/C901.html @engelke do you have any tips on this? |
|
A guess. There are several if statements in a row, so it will check them
all even after one is matched. Make them elif instead. Also, maybe move the
body of the if __name__ == main to a function named main.
*From: *Frank Natividad <notifications@github.com>
*Date: *Wed, May 8, 2019, 1:37 PM
*To: *GoogleCloudPlatform/python-docs-samples
*Cc: *Charles Engelke, Mention
Reading more on it here:
… https://lintlyci.github.io/Flake8Rules/rules/C901.html
@engelke <https://github.com/engelke> do you have any tips on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2142 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAT6NYBN3BWNQSFSMSTZZLPUM2XXANCNFSM4HLEJTCQ>
.
|
|
Looks like it's passing now :) |
frankyn
approved these changes
May 9, 2019
|
Thanks @jkwlui! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.