Demo webserver for managed instances tutorial #2077
Conversation
|
The linter fails on a few lines over the line limit that are part of a multi-line HTML template string: '''IN-LINE Let me know if this is, in fact, an ugly way to define an index.html page for a python HTTP server, and I'll find a way to refactor. |
|
I've updated the server to use Flask. |
| if r.status_code == 200: | ||
| return sub(r'.+zones/(.+)', r'\1', r.text) | ||
| else: | ||
| return '' |
There was a problem hiding this comment.
Are there any failure cases here that we should be throwing errors on instead of returning the empty string? This seems like unexpected behavior.
There was a problem hiding this comment.
Unsuccessfully getting the zone is not a critical failure. The zone (and the template) are fetched simply for informational purposes on the UI. The demo still works perfectly fine if both fetches fail. If I were to put something in the failure case, it would be an error message along the lines of 'zone not found'/'template not found'.
|
|
||
| PORT_NUMBER = 80 | ||
| HTML_TEMPLATES_PATH = path.dirname(path.realpath(__file__)) + '/templates' | ||
| HEALTHY = True |
There was a problem hiding this comment.
Does this sample ever have multiple instances behind a load balancer, or is it intended to run on one machine at a time only?
There was a problem hiding this comment.
In the future, I intend to run this sample with a load balancer.
The global 'healthy' is meant to simply hold state for each individual server. It is expected that a user might be redirected to different servers by the load balancer. Please let me know if there is a more idiomatic way of hosting a simple boolean state variable on a flask server (all I can find are examples using databases which seems too overcomplicated for this task).
|
Looks like there's a linting error with the new comments... sorry it's so nitpicky. If that's resolved I can merge right away. Thanks for your work on this. |
|
Comments fixed, all checks passed! |
|
Thanks, I'll merge now. |
A simple demo web server used in a new interactive tutorial: Highly Available Deployments with Autohealing