Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

BigQuery & Storage notebook tutorials #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 11, 2019
Merged

BigQuery & Storage notebook tutorials #1975

merged 25 commits into from
Feb 11, 2019

Conversation

alixhami
Copy link
Contributor

Adds GCP notebook tutorials

@alixhami alixhami requested review from tswast and frankyn January 23, 2019 19:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 23, 2019
tswast
tswast reviewed Jan 23, 2019
View reviewed changes
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/BigQuery Basics_output.ipynb Outdated Show resolved Hide resolved
notebooks/test/executed_notebooks/Storage Client Library_output.ipynb Outdated Show resolved Hide resolved
@alixhami
Copy link
Contributor Author

The markdown rendering is getting garbled for DataFrames. Looking into it now.

@tswast
Copy link
Contributor

tswast commented Jan 25, 2019

The markdown rendering is getting garbled for DataFrames. Looking into it now.

Doesn't look too garbled to me. Just that GitHub doesn't let you restyle things with a <style> tag, so it's escaping those characters. You might want to try removing those style blocks (maybe with a regex looking to replace <style.*?</style> with ''.

tswast
tswast reviewed Jan 25, 2019
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BQ code samples LGTM.

Is the code to generate the rendered markdown in this PR? I'm not seeing it or any changes to the noxfile.

@alixhami
Copy link
Contributor Author

@tswast My notebook runner/executer isn't in the PR yet. I'm still making a lot of changes to it, but I wanted to get the content out for review while I'm working on it.

frankyn
frankyn suggested changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alixhami, thanks for your patience. I did a first pass.

notebooks/rendered/unexecuted/Storage Commands.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Client Library.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Client Library.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Client Library.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Client Library.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Commands.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Commands.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Commands.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Commands.md Outdated Show resolved Hide resolved
notebooks/rendered/executed/Storage Client Library.md Outdated Show resolved Hide resolved
frankyn
frankyn suggested changes Jan 29, 2019
View reviewed changes
Copy link
Contributor

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit, overall LGTM.

notebooks/rendered/executed/storage-client-library.md Outdated Show resolved Hide resolved
alixhami added 18 commits February 8, 2019 13:05
@alixhami
initial notebook tutorials
fc86a71
@alixhami
add rendered notebooks folder
1b23b58
@alixhami
ignore executed notebooks and save executed and unexecuted rendered c…
a0c7958 
…opies
@alixhami
remove extra cell with explicit project name
ffadfbf
@alixhami
add list datasets command
29daa2f
@alixhami
rename rendered markdown files and remove styles
7979e22
@alixhami
content fixes per Frank's comments
422c8c6
@alixhami
updated storage notebooks per feedback session with Frank
82778a4
@alixhami
update storage notebooks per nstock's comments
35ecad5
@alixhami
add BQML tutorial from codelab
e9d1120
@alixhami
add alixhami as notebooks codeowner
87cc6b4
@alixhami
update tables from markdown to html to solve rendering issue
1a4edba
@alixhami
update to use dataset_id variable and interpolation
efccfa6
@alixhami
updates to python3 kernel from virtualenv
154635e
@alixhami
remove unexecuted rendered notebooks
386bef8
@alixhami
update bqml tutorial to getting started for data scientists
0287d5f
@alixhami
update bq tutorials per Jeff's comments
c9c688a
@alixhami
fixes titles to be sentence case
d183113
@alixhami alixhami changed the title [WIP] GCP Notebook Tutorials BigQuery & Storage notebook tutorials Feb 8, 2019
tswast
tswast approved these changes Feb 8, 2019
View reviewed changes
notebooks/rendered/bigquery-basics.md Show resolved Hide resolved
notebooks/rendered/bigquery-query-magic.md Show resolved Hide resolved
notebooks/rendered/getting-started-with-bigquery-ml.md Outdated Show resolved Hide resolved
@alixhami alixhami merged commit 03e4788 into master Feb 11, 2019
@alixhami alixhami deleted the notebook-tutorials branch February 11, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @tswast @frankyn @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.