Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Asset] Add requirements.txt #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Nov 13, 2018
Merged

[Asset] Add requirements.txt #1834

merged 19 commits into from
Nov 13, 2018

Conversation

peter-zheng-g
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 13, 2018
Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things I missed in the initial review. Sorry for that, let's take another look tomorrow morning before my meetings.

asset/cloud-client/requirements.txt Outdated Show resolved Hide resolved
asset/cloud-client/quickstart_exportassets_test.py Outdated Show resolved Hide resolved
@peter-zheng-g
Copy link
Contributor Author

Thanks!

@gguuss
Copy link
Contributor

gguuss commented Nov 13, 2018

Please update the branch.

asset/cloud-client/quickstart_exportassets.py Show resolved Hide resolved
except Exception:
pass
except Exception as e:
print('Failed to delete bucket{}'.format(BUCKET))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space between bucket and {}:

print('Failed to delete bucket: {}'.format(BUCKET))

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, consider cleaning up your formatting on the exception in the test.

@gguuss gguuss merged commit 1d868fb into GoogleCloudPlatform:master Nov 13, 2018
arithmetic1728 pushed a commit to googleapis/python-asset that referenced this pull request Jul 31, 2020
busunkim96 pushed a commit to googleapis/python-asset that referenced this pull request Aug 4, 2020
engelke pushed a commit that referenced this pull request Nov 28, 2022
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.