Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

GCF: Add samples for billing #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2018
Merged

GCF: Add samples for billing #1725

merged 3 commits into from
Oct 5, 2018

Conversation

ace-n
Copy link

@ace-n ace-n commented Sep 27, 2018

No description provided.

Change-Id: Ie43de503c9600f23b7bb168e62948a01f868457d
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 27, 2018
Copy link
Member

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comment is addressed. Please review if slack is the most straightforward notification strategy, but don't spend too much time on it unless there's something manifestly better. Please also run the tests manually (CI is broken), especially lint tests.

functions/billing/main.py Show resolved Hide resolved
Ace Nassri added 2 commits September 28, 2018 18:04
Change-Id: Iaa73d0548b5196a9e002b330165fd09c172928da
Change-Id: I537817dda32abb03629e8ebc4c9e45d69efb59f7
@ace-n ace-n merged commit 7e07ff8 into master Oct 5, 2018
@ace-n ace-n deleted the slack-billing branch October 5, 2018 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.