Adding ability to make reqeusts of all method types: GET, POST, PUT etc #1481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
approved these changes
May 15, 2018
iap/make_iap_request.py
Outdated
| client_id: The client ID used by Identity-Aware Proxy. | ||
| method: The request method to use | ||
| ('GET', 'OPTIONS', 'HEAD', 'POST', 'PUT', 'PATCH', 'DELETE') | ||
| **kwargs: Any of the parameters defined for the Request class: |
Member
There was a problem hiding this comment.
In this case, I think it's the request function rather than the request class.
iap/make_iap_request.py
Outdated
| method: The request method to use | ||
| ('GET', 'OPTIONS', 'HEAD', 'POST', 'PUT', 'PATCH', 'DELETE') | ||
| **kwargs: Any of the parameters defined for the Request class: | ||
| https://github.com/requests/requests/blob/9616f82905f86173477fdb3bf24f2f7228eed3a0/requests/api.py#L16 |
Member
There was a problem hiding this comment.
Let's link to the default branch, without a line specified (https://github.com/requests/requests/blob/master/requests/api.py). Our requests version is updated by an automated system, so unless we are very general in our link it will be out of date almost immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.