feat(bigquery): create cloud-client samples #13147
Merged
+797
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Samples must be moved back to this directory.
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
- Change function name and region tag from '_policies' to '_policy', to match documentation - Add more explanation to how the Access policy is retreived as a list of Access Entries - Add a validation to check if 'access_entries' has elements
There was a problem hiding this comment.
It looks like the conftest was copied from https://github.com/googleapis/python-bigquery/blob/main/samples/snippets/conftest.py
Other samples there will eventually have to be moved here so we can keep it mostly intact to avoid breaking other samples when they land here.
9 tasks
- Change typing imports as per PEP-585 and PEP-604 - Remove dependencies for Python < 3.9 - Refactor overriding values - Remove CLI entry point
- Refactor creating and deleting datasets into a single fixture. - Refactor reading stdout/stderr to returning the dataset and asserting it has the right name. - Validate that the dataset was deleted successfully.
- Assert over an Access policy, not the Dataset itself
| # https://cloud.google.com/python/docs/reference/bigquery/latest/google.cloud.bigquery.dataset.AccessEntry | ||
|
|
||
| # Get properties for an AccessEntry | ||
| if dataset.access_entries: |
There was a problem hiding this comment.
That might be because you're indexing over the first element in the list, so you're trying to iterate over a single value rather than the list itself. Would it work if you try this? (note removing the [0])
for key, value in dataset.access_entries:
print(key, value)- Leave only one way to print access_entries, and refactor with a for to show all list elements. - Remove unnecessary validation for deleting dataset. - Remove unnecessary fixture for a second table when first one could be used to create the view. - Remove magic value for empty policy.
- Works better when there is an empty AccessEntry list.
- Simplify use of fixtures. - Apply diverse feedback from the team.
- Hardcoding the EntityType to simplify the sample.
…nify it to Node.JS one - Allow to revoke access by role or by principal_id.
- Add entity_id - Remove unused comments
- Update principal_id sample with a valid identifier.
- Remove unnecesary code. - Rewrite comments and documentation references. - Add __future__ annotations for Python 3.9
davidcavazos
approved these changes
Feb 19, 2025
- Rename 'bigquery_client' to 'client' to make it consistent across samples. - Add validation for empty bindings list in 'view_table_or_access_policy'. - Add '_id' suffix to placeholder.
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Step of Internal: b/394478489
Samples
Checklist
nox -s py-3.13(see Test Environment Setup)nox -s lint(see Test Environment Setup)