-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 1 #13095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:
This pull request, "chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 1", aims to migrate region tags in Dockerfiles and YAML files from the run
folder. This is a follow-up to PR #4951 and addresses internal issues b/347349699 and b/347350333.
The changes include adding _python
to the existing region tags in several files:
run/django/cloudmigrate.yaml
: Added_python
to the[START]
and[END]
tags (lines 15-16 and 72-73).run/hello-broken/Dockerfile
: Added_python
to the[START]
and[END]
tags (lines 15-16 and 44-45).run/helloworld/Dockerfile
: Added_python
to the[START]
and[END]
tags (lines 15-16 and 40-41).run/image-processing/Dockerfile
: Added_python
to the[START]
and[END]
tags (lines 29-30 and 38-39).
The author has indicated that tests and lint checks have passed.
And now, a little haiku to brighten your day:
Code flows like a stream,
Tags updated, clean and bright,
Review, then merge on!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request migrates region tags for Dockerfiles and a YAML file. The changes are straightforward and easy to understand. The added region tags seem correctly placed and follow the naming convention used in other files in the repository. The checklist confirms that tests and lint checks pass, which is good. However, I have a few minor suggestions for improvement.
I noticed that the pull request description references the AUTHORING_GUIDE.md
file. I've reviewed this file and used it to inform my feedback, specifically the sections on Region Tags and README File.
Here is the summary of changes. You are about to add 4 region tags.
You are about to delete 2 region tags.
This comment is generated by snippet-bot.
|
Description
Fixes Internal:
b/347349699
b/347350333
Follow-up of #4951
Checklist
nox -s py-3.12
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)