Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 1 #13095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal:
b/347349699
b/347350333

Follow-up of #4951

Checklist

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly understand the changes:

This pull request, "chore(cloudrun): migrate region tags for dockerfiles and yaml from run folder - part 1", aims to migrate region tags in Dockerfiles and YAML files from the run folder. This is a follow-up to PR #4951 and addresses internal issues b/347349699 and b/347350333.

The changes include adding _python to the existing region tags in several files:

  • run/django/cloudmigrate.yaml: Added _python to the [START] and [END] tags (lines 15-16 and 72-73).
  • run/hello-broken/Dockerfile: Added _python to the [START] and [END] tags (lines 15-16 and 44-45).
  • run/helloworld/Dockerfile: Added _python to the [START] and [END] tags (lines 15-16 and 40-41).
  • run/image-processing/Dockerfile: Added _python to the [START] and [END] tags (lines 29-30 and 38-39).

The author has indicated that tests and lint checks have passed.


And now, a little haiku to brighten your day:

Code flows like a stream,
Tags updated, clean and bright,
Review, then merge on!

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. labels Jan 24, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates region tags for Dockerfiles and a YAML file. The changes are straightforward and easy to understand. The added region tags seem correctly placed and follow the naming convention used in other files in the repository. The checklist confirms that tests and lint checks pass, which is good. However, I have a few minor suggestions for improvement.

I noticed that the pull request description references the AUTHORING_GUIDE.md file. I've reviewed this file and used it to inform my feedback, specifically the sections on Region Tags and README File.

@eapl-gemugami eapl-gemugami added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 24, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 24, 2025
Copy link

snippet-bot bot commented Jan 24, 2025

Here is the summary of changes.

You are about to add 4 region tags.
You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@glasnt glasnt added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2025
@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 27, 2025 15:19
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 27, 2025 15:19
@davidcavazos davidcavazos merged commit e42ea58 into GoogleCloudPlatform:main Jan 27, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/cloudrun/fix-region-tags-from-run-dockerfiles-and-yaml-part-1 branch January 27, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.