-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore(gae): rename region tags from standard/urlfetch async and snippets folders #13091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by @eapl-gemugami, aims to rename region tags in the App Engine standard/urlfetch
async and snippets folders. The changes address internal issues b/391860645 and b/391860649.
Here's a breakdown of the changes:
-
Files Changed:
appengine/standard/urlfetch/async/requirements-test.txt
: Added pytest version pinning for Python 2 and 3 compatibility.appengine/standard/urlfetch/async/requirements.txt
: Added a single empty line (possibly a cleanup).appengine/standard/urlfetch/async/rpc.py
: Renamed several comment tags fromurlfetch
togae_urlfetch_async
(e.g.,[START urlfetch-import]
became[START gae_urlfetch_async_import]
).appengine/standard/urlfetch/snippets/main.py
: Similar renaming of comment tags fromurlfetch
togae_urlfetch_snippets
(e.g.,[START urlfetch-imports]
became[START gae_urlfetch_snippets_imports_urlfetch]
).appengine/standard/urlfetch/snippets/requirements-test.txt
: Added pytest version pinning for Python 2 and 3 compatibility.appengine/standard/urlfetch/snippets/requirements.txt
: Added a single empty line (possibly a cleanup).
-
Summary of Changes: The core change is a consistent renaming of comment tags across multiple files within the
standard/urlfetch
directory. This appears to be a refactoring effort to improve consistency and potentially prepare for future changes.
The author has indicated that tests and lint checks have passed.
And now for a little fun, a haiku to brighten your day:
Code flows like a stream,
Tags renamed, a cleaner sight,
Reviews make it shine.
Thanks,
Gemini/code-review-assist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request renames region tags across multiple files related to URL Fetch in App Engine. The changes are consistent and improve clarity by using more specific tag names. The commit messages clearly explain the purpose of the changes, and the provided checklist confirms adherence to project guidelines. I've referenced the Google Python Style Guide for this review.
Description
Fixes Internal:
b/391860645
b/391860649
Checklist
nox -s py-3.12
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)