Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

chore(gae): rename region tags from standard/urlfetch async and snippets folders #13091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

eapl-gemugami
Copy link
Contributor

Description

Fixes Internal:
b/391860645
b/391860649

Checklist

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 23, 2025
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @eapl-gemugami, aims to rename region tags in the App Engine standard/urlfetch async and snippets folders. The changes address internal issues b/391860645 and b/391860649.

Here's a breakdown of the changes:

  • Files Changed:

    • appengine/standard/urlfetch/async/requirements-test.txt: Added pytest version pinning for Python 2 and 3 compatibility.
    • appengine/standard/urlfetch/async/requirements.txt: Added a single empty line (possibly a cleanup).
    • appengine/standard/urlfetch/async/rpc.py: Renamed several comment tags from urlfetch to gae_urlfetch_async (e.g., [START urlfetch-import] became [START gae_urlfetch_async_import]).
    • appengine/standard/urlfetch/snippets/main.py: Similar renaming of comment tags from urlfetch to gae_urlfetch_snippets (e.g., [START urlfetch-imports] became [START gae_urlfetch_snippets_imports_urlfetch]).
    • appengine/standard/urlfetch/snippets/requirements-test.txt: Added pytest version pinning for Python 2 and 3 compatibility.
    • appengine/standard/urlfetch/snippets/requirements.txt: Added a single empty line (possibly a cleanup).
  • Summary of Changes: The core change is a consistent renaming of comment tags across multiple files within the standard/urlfetch directory. This appears to be a refactoring effort to improve consistency and potentially prepare for future changes.

The author has indicated that tests and lint checks have passed.


And now for a little fun, a haiku to brighten your day:

Code flows like a stream,
Tags renamed, a cleaner sight,
Reviews make it shine.

Thanks,
Gemini/code-review-assist

@product-auto-label product-auto-label bot added the api: appengine Issues related to the App Engine Admin API API. label Jan 23, 2025
@eapl-gemugami eapl-gemugami added snippet-bot:force-run Force snippet-bot runs its logic and removed api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples. labels Jan 23, 2025
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 23, 2025
Copy link

snippet-bot bot commented Jan 23, 2025

Here is the summary of changes.

You are about to add 8 region tags.
You are about to delete 8 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request renames region tags across multiple files related to URL Fetch in App Engine. The changes are consistent and improve clarity by using more specific tag names. The commit messages clearly explain the purpose of the changes, and the provided checklist confirms adherence to project guidelines. I've referenced the Google Python Style Guide for this review.

appengine/standard/urlfetch/async/rpc.py Show resolved Hide resolved
appengine/standard/urlfetch/async/rpc.py Show resolved Hide resolved
@eapl-gemugami eapl-gemugami added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@eapl-gemugami eapl-gemugami added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jan 23, 2025
@eapl-gemugami eapl-gemugami marked this pull request as ready for review January 23, 2025 18:30
@eapl-gemugami eapl-gemugami requested review from a team as code owners January 23, 2025 18:30
@iennae iennae merged commit d0205c0 into GoogleCloudPlatform:main Jan 23, 2025
11 checks passed
@eapl-gemugami eapl-gemugami deleted the paradalicea/chore/gae/rename-region-tags-from-standard-urlfetch-async-and-snippets branch January 23, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.