Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

fix: sqlalchemy dependencies#12760

Merged
jackwotherspoon merged 5 commits intoGoogleCloudPlatform:mainGoogleCloudPlatform/python-docs-samples:mainfrom
wiktorn:cloudsql-sqlalchemy-verison-bumpwiktorn/python-docs-samples:cloudsql-sqlalchemy-verison-bumpCopy head branch name to clipboard
Jan 23, 2025
Merged

fix: sqlalchemy dependencies#12760
jackwotherspoon merged 5 commits intoGoogleCloudPlatform:mainGoogleCloudPlatform/python-docs-samples:mainfrom
wiktorn:cloudsql-sqlalchemy-verison-bumpwiktorn/python-docs-samples:cloudsql-sqlalchemy-verison-bumpCopy head branch name to clipboard

Conversation

@wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Nov 10, 2024

Description

SQLAlchemy v2.0.24 fails with Python 3.13 with error:

AssertionError: Class <class 'sqlalchemy.sql.elements.SQLCoreOperations'> directly inherits TypingOnly but has additional attributes {'__static_attributes__'}.

see bug #11334

Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid such problems in the future.

Checklist

@wiktorn wiktorn requested review from a team as code owners November 10, 2024 08:36
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudsql labels Nov 10, 2024
@jackwotherspoon
Copy link
Contributor

jackwotherspoon commented Nov 11, 2024

@wiktorn wouldn't MySQL and SQL Server folders also benefit from this change?

MySQL: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/cloud-sql/mysql/sqlalchemy
SQL Server: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/cloud-sql/sql-server/sqlalchemy

@wiktorn
Copy link
Contributor Author

wiktorn commented Nov 11, 2024

@jackwotherspoon Actually, both MySQL and SQL Server pinned python:3.11 (though different flavors). I aligned Dockerfiles and requirements.txt across these three.

iennae
iennae reviewed Nov 21, 2024
View reviewed changes
cloud-sql/mysql/sqlalchemy/Dockerfile Outdated Show resolved Hide resolved
iennae
iennae reviewed Nov 21, 2024
View reviewed changes
cloud-sql/postgres/sqlalchemy/Dockerfile Outdated Show resolved Hide resolved
@iennae iennae added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 21, 2024
@iennae iennae requested a review from a team as a code owner November 21, 2024 07:06
@jackwotherspoon
Copy link
Contributor

jackwotherspoon commented Jan 23, 2025

Hi @wiktorn anything I can help with to get this PR across the line? 😄

It is blocking PR #12858 as Python 3.13 tests are now enabled on this repo

@jackwotherspoon
Copy link
Contributor

jackwotherspoon commented Jan 23, 2025

I have fixed the previous errors about the missing env vars so 🤞 builds should all pass after rebasing the PR

wiktorn and others added 5 commits January 23, 2025 15:18
@wiktorn
fix: sqlalchemy dependencies
9ef1816 
SQLAlchemy v2.0.24 fails with Python 3.13 with error:
```
AssertionError: Class <class 'sqlalchemy.sql.elements.SQLCoreOperations'> directly inherits TypingOnly but has additional attributes {'__static_attributes__'}.
```
[see bug GoogleCloudPlatform#11334](sqlalchemy/sqlalchemy#11334)

Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid
such problems in the future.
@wiktorn
fix: Align mysql/pgsql/sqlserver Dockerfile and requirements.txt
dff43ec
@iennae @wiktorn
chore: revert license year and fix Google LLC
21f7e9d
@iennae @wiktorn
chore: revert license year and fix Google LLC
ebe088f
@wiktorn
fix: review fixes
6764846
@wiktorn wiktorn force-pushed the cloudsql-sqlalchemy-verison-bump branch from 6306134 to 6764846 Compare January 23, 2025 15:18
@wiktorn
Copy link
Contributor Author

wiktorn commented Jan 23, 2025

Thanks @jackwotherspoon I just rebased, hopefully this will solve the issue!

@jackwotherspoon jackwotherspoon added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 23, 2025
@jackwotherspoon
Copy link
Contributor

jackwotherspoon commented Jan 23, 2025

Looks like all tests passed, just lint job failed for unable to get service account (flaky?), re-running tests to see if it was a a one off

jackwotherspoon
jackwotherspoon approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Thanks @wiktorn looks like we are all green 👍

@jackwotherspoon jackwotherspoon merged commit dfdeaad into GoogleCloudPlatform:main Jan 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jackwotherspoon jackwotherspoon jackwotherspoon approved these changes

@iennae iennae Awaiting requested review from iennae

Assignees

@jackwotherspoon jackwotherspoon

Labels

api: cloudsql samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wiktorn @jackwotherspoon @iennae @kokoro-team @hessjcg

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.