Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: (Gen AI): Add sample for Gemini parallel function calling example #12637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Valeriy-Burlaka
Copy link
Member

@Valeriy-Burlaka Valeriy-Burlaka commented Sep 26, 2024

Description

Updates the existing update_context_cache sample to account for a variation listed in the "Update the context cache using its expire_time parameter" section of the multimodal/function-calling Vertex AI page.

As discussed with @msampathkumar, the ttl example and the expire_time examples are almost identical, and adding a new sample for a single parameter change brings very little value , so it's better to merge these examples into one.

Checklist

  • I have followed Sample Guidelines from AUTHORING_GUIDE.MD
  • README is updated to include all relevant information
  • Tests pass: nox -s py-3.8 and nox -s py-3.11
  • Lint pass: nox -s lint
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@Valeriy-Burlaka Valeriy-Burlaka self-assigned this Sep 26, 2024
@Valeriy-Burlaka Valeriy-Burlaka requested review from a team as code owners September 26, 2024 17:46
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 26, 2024
@msampathkumar msampathkumar self-assigned this Sep 26, 2024
Copy link

snippet-bot bot commented Sep 26, 2024

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@msampathkumar msampathkumar added the waiting-response Waiting for the author's response. label Oct 3, 2024
Copy link
Member

@msampathkumar msampathkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Valeriy-Burlaka Valeriy-Burlaka merged commit bfcf355 into GoogleCloudPlatform:main Oct 3, 2024
11 checks passed
riathakkar pushed a commit to riathakkar/python-docs-samples that referenced this pull request Oct 8, 2024
…le (GoogleCloudPlatform#12637)

* Add Python sample for Gemini parallel function calling

* Update model version

* rename test file to follow standard naming practice

* move function_calling tests into a single file

* give up to the pylint import-order unconfigured check

* refresh CI checks

* update region name to follow up the standard schema

* update region tag name after a discussion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.