Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat(Makefile): use make to run kokoro tests #10938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Feb 29, 2024
Merged

feat(Makefile): use make to run kokoro tests #10938

merged 10 commits into from
Feb 29, 2024

Conversation

muncus
Copy link
Contributor

@muncus muncus commented Nov 17, 2023 •
edited
Loading

Update kokoro CI testing to use the Makefile-based testing method.

this required additions to the Makefile to pass along the $RUN_TESTS_SESSION through. We're currently aiming for minimal changes to kororo scripts, though there is likely room for future simplification.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 17, 2023
@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 20, 2023
@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2023
@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 27, 2023
@muncus muncus marked this pull request as ready for review November 28, 2023 23:39
@muncus muncus requested a review from a team as a code owner November 28, 2023 23:39
@muncus
Copy link
Contributor Author

muncus commented Nov 28, 2023

The failing 3.12 tests are consistent with the current periodic tests, which supports that they are unrelated to this change. (incidentally, it looks like these issues are related to distutils removal

@muncus
Copy link
Contributor Author

muncus commented Jan 29, 2024

Ping. Can I get a review on this PR please? It has been waiting for over two months.

The failing tests match tests that fail in the nightly 'periodic' builds, and do not appear to be caused by this change.

Python is the only remaining Gold language that does not use the Makefile to run CI.

@m-strzelczyk m-strzelczyk removed their assignment Feb 8, 2024
@muncus muncus added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@muncus
Copy link
Contributor Author

muncus commented Feb 8, 2024

This PR will need a repo owner/maintainer to force merge, since the required PR checks will not pass.

because this PR modifies files in .kokoro/tests, all tests will be run, making this presubmit as thorough as the periodic builds.

The python 3.8 periodic tests have not been green since November.
The python 3.12 periodic tests have not been green since their creation.

please force merge at your earliest convenience.

@leahecole leahecole assigned m-strzelczyk and unassigned leahecole Feb 9, 2024
@m-strzelczyk m-strzelczyk merged commit da907f0 into main Feb 29, 2024
@m-strzelczyk m-strzelczyk deleted the ci-make branch February 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muncus @m-strzelczyk @leahecole @kokoro-team
Morty Proxy This is a proxified and sanitized view of the page, visit original site.