feat(dlp): #10786 with shorter commits - "Split Custom Infotype samples into multiple files " #10883

Avani-Thakker-Crest · Oct 30, 2023

Description

This PR is similar to #10786 but with shorter commits to maintain history
Fix PR as part of the issue: #10601
This PR only splits custom infotype related samples into multiple files

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

I have followed Sample Guidelines from AUTHORING_GUIDE.MD
README is updated to include all relevant information
Tests pass: nox -s py-3.9 (see Test Environment Setup)
Lint pass: nox -s lint (see Test Environment Setup)
These samples need a new API enabled in testing projects to pass (let us know which ones)
These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
Please merge this PR for me once it is approved

snippet-bot · Oct 30, 2023

Here is the summary of changes.

You are about to add 11 region tags.

dlp/snippets/Custom_Infotype/inspect_custom_regex.py:20, tag dlp_inspect_custom_regex
dlp/snippets/Custom_Infotype/inspect_hotword_rule.py:20, tag dlp_inspect_hotword_rule
dlp/snippets/Custom_Infotype/inspect_string_custom_excluding_substring.py:20, tag dlp_inspect_string_custom_excluding_substring
dlp/snippets/Custom_Infotype/inspect_string_custom_hotword.py:20, tag dlp_inspect_string_custom_hotword
dlp/snippets/Custom_Infotype/inspect_string_custom_omit_overlap.py:20, tag dlp_inspect_string_custom_omit_overlap
dlp/snippets/Custom_Infotype/inspect_string_multiple_rules.py:20, tag dlp_inspect_string_multiple_rules
dlp/snippets/Custom_Infotype/inspect_string_omit_overlap.py:20, tag dlp_inspect_string_omit_overlap
dlp/snippets/Custom_Infotype/inspect_string_with_exclusion_dict.py:20, tag dlp_inspect_string_with_exclusion_dict
dlp/snippets/Custom_Infotype/inspect_string_with_exclusion_dict_substring.py:20, tag dlp_inspect_string_with_exclusion_dict_substring
dlp/snippets/Custom_Infotype/inspect_string_with_exclusion_regex.py:20, tag dlp_inspect_string_with_exclusion_regex
dlp/snippets/Custom_Infotype/inspect_string_without_overlap.py:20, tag dlp_inspect_string_without_overlap

You are about to delete 11 region tags.

dlp/snippets/custom_infotype.py:20, tag dlp_inspect_string_with_exclusion_dict
dlp/snippets/custom_infotype.py:100, tag dlp_inspect_string_with_exclusion_regex
dlp/snippets/custom_infotype.py:176, tag dlp_inspect_string_with_exclusion_dict_substring
dlp/snippets/custom_infotype.py:254, tag dlp_inspect_string_custom_excluding_substring
dlp/snippets/custom_infotype.py:335, tag dlp_inspect_string_custom_omit_overlap
dlp/snippets/custom_infotype.py:415, tag dlp_inspect_string_omit_overlap
dlp/snippets/custom_infotype.py:492, tag dlp_inspect_string_without_overlap
dlp/snippets/custom_infotype.py:577, tag dlp_inspect_string_custom_hotword
dlp/snippets/custom_infotype.py:647, tag dlp_inspect_string_multiple_rules
dlp/snippets/custom_infotype.py:736, tag dlp_inspect_custom_regex
dlp/snippets/custom_infotype.py:799, tag dlp_inspect_hotword_rule

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

micheldavid

Honestly this wasn't much easier to review than #10601, but I appreciate the effort. thank you.

Avani-Thakker-Crest added 13 commits October 30, 2023 17:13

moved inspect_string_with_exclusion_dict into separate file

8f40ba9

moved inspect_custom_regex into separate file

21f85af

moved inspect_hotword_rule into separate file

f12bb18

moved inspect_hotword_rule into separate file

5ea1fc7

moved inspect_string_custom_excluding_substring into separate file

ea5849b

moved inspect_string_custom_hotword into separate file

b2234c3

moved inspect_string_custom_omit_overlap into separate file

32df695

moved inspect_string_multiple_rules into separate file

1080a78

moved inspect_string_omit_overlap into separate file

7b9e7b3

moved inspect_string_with_exclusion_dict_substring into separate file

11bec81

moved inspect_string_with_exclusion_regex into separate file

986c067

moved inspect_string_without_overlap into separate file

5ddfae0

removed older file for custom_infotype

3594f19

Avani-Thakker-Crest requested review from a team as code owners October 30, 2023 12:06

product-auto-label bot added api: dlp Issues related to the Sensitive Data Protection API. samples Issues that are directly related to samples. labels Oct 30, 2023

blunderbuss-gcf bot assigned jakubrauch Oct 30, 2023

Avani-Thakker-Crest mentioned this pull request Oct 30, 2023

feat(dlp): Split Custom Infotype samples into multiple files such that each region tag gets its own file #10786

Closed

9 tasks

Avani-Thakker added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2023

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2023

micheldavid approved these changes Oct 30, 2023

View reviewed changes

rsamborski approved these changes Oct 31, 2023

View reviewed changes

rsamborski merged commit dc432cf into GoogleCloudPlatform:main Oct 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(dlp): #10786 with shorter commits - "Split Custom Infotype samples into multiple files " #10883

feat(dlp): #10786 with shorter commits - "Split Custom Infotype samples into multiple files " #10883

Uh oh!

Avani-Thakker-Crest commented Oct 30, 2023 •

edited

Loading

Uh oh!

snippet-bot bot commented Oct 30, 2023

Uh oh!

micheldavid left a comment

Uh oh!

Uh oh!

Search code, repositories, users, issues, pull requests...

feat(dlp): #10786 with shorter commits - "Split Custom Infotype samples into multiple files " #10883

feat(dlp): #10786 with shorter commits - "Split Custom Infotype samples into multiple files " #10883

Uh oh!

Conversation

Avani-Thakker-Crest commented Oct 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

snippet-bot bot commented Oct 30, 2023

Uh oh!

micheldavid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Avani-Thakker-Crest commented Oct 30, 2023 •

edited

Loading