Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

werkzeug flask upgrade #10878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 27, 2023
Merged

werkzeug flask upgrade #10878

merged 10 commits into from
Oct 27, 2023

Conversation

leahecole
Copy link
Collaborator

@leahecole leahecole commented Oct 26, 2023 •
edited
Loading

This PR upgrades Werkzeug to >3.x and Flask to >3.x where possible. In a couple of instances, slight code adjustments were made to fix code that changed in the major version upgrades.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: pubsub Issues related to the Pub/Sub API. api: run Issues related to the Cloud Run API. labels Oct 26, 2023
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@leahecole leahecole removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@leahecole leahecole changed the title cloud run werkzeug flask Oct 26, 2023
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 26, 2023
@leahecole leahecole marked this pull request as ready for review October 26, 2023 23:50
@leahecole leahecole requested review from a team, ymotongpoo and yuriatgoogle as code owners October 26, 2023 23:50
@leahecole leahecole added the snippet-bot:force-run Force snippet-bot runs its logic label Oct 26, 2023
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Oct 26, 2023
@leahecole leahecole changed the title werkzeug flask werkzeug flask upgrade Oct 26, 2023
@leahecole leahecole assigned dandhlee and unassigned kamalaboulhosn Oct 26, 2023
engelke
engelke approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole merged commit 8941e0b into main Oct 27, 2023
@leahecole leahecole deleted the werkzeug_flask branch October 27, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

@glasnt glasnt glasnt approved these changes

@ymotongpoo ymotongpoo Awaiting requested review from ymotongpoo

@yuriatgoogle yuriatgoogle Awaiting requested review from yuriatgoogle yuriatgoogle is a code owner

Assignees

@dandhlee dandhlee

Labels
api: pubsub Issues related to the Pub/Sub API. api: run Issues related to the Cloud Run API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leahecole @engelke @glasnt @kamalaboulhosn @kokoro-team @dandhlee
Morty Proxy This is a proxified and sanitized view of the page, visit original site.