Update pub/sub - appengine push request sample #10747
Conversation
|
Here is the summary of changes. You are about to add 1 region tag.
You are about to delete 1 region tag.This comment is generated by snippet-bot.
|
| # [END gae_standard_pubsub_auth_push] | ||
|
|
||
| # [START push] |
There was a problem hiding this comment.
issue: It looks as if push region tag was supposed to be changed to gae_standard_pubsub_auth_push which follows proper naming standard (prefix with product name). If you'd like to have two different samples please use a proper region tag instead of push (for example gae_standard_pubsub_push).
There was a problem hiding this comment.
Thank you for the guidance and reviewing! I fix it now per your suggestion now
|
/gcbrun |
Change regional tag - per prefix naming convention
| url, | ||
| data=json.dumps( |
There was a problem hiding this comment.
These lines and a few others are causing linting errors. Please run nox -s lint on this file and the lint checks should pass ✨
There was a problem hiding this comment.
@jwdjj it looks like this is still blocked on lint:
./main_test.py:110:5: E122 continuation line missing indentation or outdented
url,
^
./main_test.py:111:5: E122 continuation line missing indentation or outdented
data=json.dumps(
^
./main_test.py:140:5: E303 too many blank lines (2)
# no token
^
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)