-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat(dlp): Add code samples to de-identify files in Cloud Storage #10511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dlp): Add code samples to de-identify files in Cloud Storage #10511
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Hey @Avani-Thakker-Crest this file is growing to quite a big number of lines. Would it be possible to slip it into multiple files? So that for example each region tag gets its own file? It would also allow you to remove some |
Thank you @m-strzelczyk for your comment. Definitely, we can split into multiple files. Please let me know how should I split:
Please let me know which option would be appropriate to perform. Thank you! |
Hi @m-strzelczyk , for now I have created new files for this particular sample. And for the rest samples, I have created a backlog issue #10601 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting close :)
One issue with the logic inside the sample, probably easy to fix.
And one issue with increasing the depth of testing.
Description
Implemented dlp_deidentify_cloud_storage code sample and test is implemented using mocking mechanism. Json equivalent: https://cloud.google.com/dlp/docs/deidentify-storage#code-example
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)