chore(cloud-sql): update GKE sample comments #10451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandhlee
reviewed
Jul 24, 2023
Comment on lines
+78
to
+80
| # If you are not connecting with Automatic IAM, you can delete | ||
| # the following flag. | ||
| - "--auto-iam-authn" |
There was a problem hiding this comment.
Just confirming you want this to be on by default? It conflicts with the advice above that using Automatic IAM is recommended but it's on by default here
There was a problem hiding this comment.
Yes this being on is fine, enabling it still allows users to connect via regular user and password authn, the flag just enables the additional ability for auto IAM authN and doesn't strictly force it.
|
@dandhlee this is ready for another pass when you have a second |
rsamborski
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding comments to GKE Cloud SQL sample to highlight recommended use.