Datalabeling beta samples #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
kurtisvg
approved these changes
Apr 4, 2019
kurtisvg
suggested changes
Apr 4, 2019
Contributor
kurtisvg
left a comment
There was a problem hiding this comment.
I don't think we should be commenting out tests to get samples merged - the tests are supposed to be there to verify the samples are functioning correctly.
Contributor
Author
|
@kurtisvg thanks. working with product team now to figure out what could be going on here. |
Contributor
Author
|
@kurtisvg Please review. Fixed the tests. |
kurtisvg
approved these changes
Apr 4, 2019
Contributor
kurtisvg
left a comment
There was a problem hiding this comment.
couple of small nits, but LGTM
datalabeling/beta/cloud-client/src/main/java/com/example/datalabeling/LabelImage.java
Show resolved
Hide resolved
datalabeling/beta/cloud-client/src/main/java/com/example/datalabeling/LabelText.java
Outdated
Show resolved
Hide resolved
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
* Datalabeling beta samples * Fixing tests * Fixing tests * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * debugging * debugging
9 tasks
averikitsch
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Datalabeling beta samples * Fixing tests * Fixing tests * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * Ignoring tests for now due to time duration. * debugging * debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stepping in for @nnegrey