Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Logging: Pass 'stream' argument to super in 'ContainerEngineHandler.__init__'. #9166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

aviau
Copy link
Contributor

@aviau aviau commented Sep 3, 2019

It looks like this was broken here: aee5cec#diff-c49b1ce108fd52ae2640bc8afc4415d7R40

@aviau aviau requested a review from busunkim96 as a code owner September 3, 2019 21:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2019
@aviau
Copy link
Contributor Author

aviau commented Sep 3, 2019

\cc @tseaver

@tseaver tseaver changed the title ContainerEngineHandler: don't swallow stream Logging: Pass 'stream' argument to super in 'ContainerEngineHandler.__init__'. Sep 3, 2019
@tseaver tseaver added api: logging Issues related to the Cloud Logging API. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 3, 2019
@tseaver tseaver merged commit 0b663e4 into googleapis:master Sep 4, 2019
@tseaver
Copy link
Contributor

tseaver commented Sep 4, 2019

@aviau Thank you for the patch!

emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 11, 2019
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.