This repository was archived by the owner on Oct 21, 2022. It is now read-only.
Do not show python version incompatible results in dashboard #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylil93
reviewed
Aug 7, 2018
| def _is_py_version_incompatible(self, result): | ||
| if result.status == compatibility_store.Status.INSTALL_ERROR: | ||
| for version in [2, 3]: | ||
| for pkg in result.packages: |
Contributor
There was a problem hiding this comment.
I think the contained if statement may have too many things going on inside of it, maybe you can split things up for example like this:
for pkg in result.packages:
major_version = result.python_major_version
name = pkg.install_name
unsupported = configs.PKG_PY_VERSION_NOT_SUPPORTED[version]
if major_version == version and name in unsupported:
return True
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.