Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings
This repository was archived by the owner on Oct 21, 2022. It is now read-only.

semver checker: do not return error msg on new args with default values #202

Open
ylil93 wants to merge 8 commits into
base: master
Choose a base branch
Loading
from
Open

semver checker: do not return error msg on new args with default values #202

ylil93 wants to merge 8 commits into from

Conversation

@ylil93
Copy link
Contributor

@ylil93 ylil93 commented Dec 12, 2018 •
edited
Loading

  • updates package crawler to only include class/function args that don't have default values
  • update docstrings/comments

brianquinlan
brianquinlan reviewed Dec 13, 2018
View reviewed changes
compatibility_lib/compatibility_lib/package_crawler_static.py Outdated Show resolved Hide resolved
brianquinlan
brianquinlan reviewed Dec 13, 2018
View reviewed changes
compatibility_lib/compatibility_lib/semver_checker.py Outdated Show resolved Hide resolved
@ylil93 ylil93 force-pushed the semver_checker branch 2 times, most recently from b6f56e6 to 18572d0 Compare December 18, 2018 21:17
@ylil93
semver checker: do not return error msg on new args with default values
8c0f6a1
@ylil93
fix typo in test name
e72032e
@ylil93
improve default arg detection
96475af 
- neither regular nor optional args cannot be removed
- args can be added as optional args
- arg order must be preserved
- default values must be preserved
- required args can be made optional
- logic currently assumes *args and **kwargs are the last two args
- added more test cases
@ylil93
clean up package_crawler
1764235
@ylil93
fix test
f2ea720
@ylil93
update default value for "args"
31b95c7
@ylil93
fix tests
50765e6
@ylil93
fix lint
51d5bf2
brianquinlan
brianquinlan reviewed Dec 22, 2018
View reviewed changes
compatibility_lib/compatibility_lib/package_crawler_static.py
'single_args': [arg1, arg2, ...],
'defaults': {arg1: value1, ...},
'vararg': argv,
'kwarg': kwargs,
Copy link
Contributor

@brianquinlan brianquinlan Dec 22, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need to know the position of these things?

Copy link
Contributor Author

@ylil93 ylil93 Jan 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get the args using ast tooling which returns the args in order.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brianquinlan brianquinlan brianquinlan approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ylil93 @brianquinlan @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.