Moving gitlab to github#7
Open
KoreySoich wants to merge 1 commit intoGlank:masterGlank/Java-Games:masterfrom
Open
Moving gitlab to github#7KoreySoich wants to merge 1 commit intoGlank:masterGlank/Java-Games:masterfrom
KoreySoich wants to merge 1 commit intoGlank:masterGlank/Java-Games:masterfrom
Conversation
Owner
|
Thanks for the contribution! I haven't pulled and tested this, but I imagine that adding these tests breaks the make files, so they would need to be excluded. Can you please also include documentation on how to run the tests? |
|
@Glank The test class need to be placed in an other package, and use some tools such as maven to manage your project. If you do this, you can run the tests before each make files. |
jfullstackdev
left a comment
There was a problem hiding this comment.
As I am reviewing this, the pull request is too broad to get the idea. Please separate this into several pull requests with respective focus or idea. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added testing to Java Games