Event for logging#20
Merged
GlaireDaggers merged 1 commit intomasterGlaireDaggers/Netcode.IO.NET:masterfrom Feb 9, 2023
unknown repositoryCopy head branch name to clipboard
Merged
Event for logging#20GlaireDaggers merged 1 commit intomasterGlaireDaggers/Netcode.IO.NET:masterfrom unknown repositoryCopy head branch name to clipboard
GlaireDaggers merged 1 commit intomasterGlaireDaggers/Netcode.IO.NET:masterfrom
unknown repositoryCopy head branch name to clipboard
Conversation
This is to allow the use of external loggers such as log4net or serilog. Documentation has been updated accordingly.
chakibchemso
approved these changes
Feb 3, 2023
chakibchemso
approved these changes
Feb 3, 2023
chakibchemso
approved these changes
Feb 3, 2023
chakibchemso
approved these changes
Feb 3, 2023
chakibchemso
approved these changes
Feb 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was planning on using this library in a project that uses Serilog for its logging. To accomplish this, I added an event that fires when the
log(...)method is called. The original behavior can easily be restored on the user's end by adding a handler toServer.OnLogMessagethatConsole.Write(...)s the event data.