Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Keep new messages separator visible when the channel is open #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 5, 2025

Conversation

laevandus
Copy link
Contributor

🔗 Issue Links

Resolves: IOS-670

🎯 Goal

Do not remove "New messages" separator when channel view is open even when marking messages as read

📝 Summary

Fixes the issue where just scrolling removes the separator.

🛠 Implementation

🎨 Showcase

Before After
img img

🧪 Manual Testing Notes

Exploratory testing with unread messages: marking unread, reading messages with scrolling

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change should be manually QAed
  • Changelog is updated with client-facing changes
  • Changelog is updated with new localization keys
  • New code is covered by unit tests
  • Documentation has been updated in the docs-content repo

@laevandus laevandus requested a review from a team as a code owner May 30, 2025 13:49
@laevandus laevandus force-pushed the fix/unread-message-separator branch from 8b15a15 to e63e606 Compare May 30, 2025 13:50
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented May 30, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 8.27 MB 8.23 MB -32 KB 🚀

Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@laevandus laevandus merged commit a2fa4cf into develop Jun 5, 2025
4 of 5 checks passed
@laevandus laevandus deleted the fix/unread-message-separator branch June 5, 2025 06:17
Copy link

sonarqubecloud bot commented Jun 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.