Added support for numeric Feature.Id values (Issue #35)#36
Open
dmitry-kandiner wants to merge 4 commits intoGeoJSON-Net:mainGeoJSON-Net/GeoJSON.Text:mainfrom
dmitry-kandiner:feature/numeric_feature_iddmitry-kandiner/GeoJSON.Text:feature/numeric_feature_idCopy head branch name to clipboard
Open
Added support for numeric Feature.Id values (Issue #35)#36dmitry-kandiner wants to merge 4 commits intoGeoJSON-Net:mainGeoJSON-Net/GeoJSON.Text:mainfrom dmitry-kandiner:feature/numeric_feature_iddmitry-kandiner/GeoJSON.Text:feature/numeric_feature_idCopy head branch name to clipboard
dmitry-kandiner wants to merge 4 commits intoGeoJSON-Net:mainGeoJSON-Net/GeoJSON.Text:mainfrom
dmitry-kandiner:feature/numeric_feature_iddmitry-kandiner/GeoJSON.Text:feature/numeric_feature_idCopy head branch name to clipboard
Conversation
Signed-off-by: Dmitry Kandiner <dmitry.kandiner@gmail.com>
Signed-off-by: Dmitry Kandiner <dmitry.kandiner@gmail.com>
95dc96d to
abcf60a
Compare
Author
|
@xfischer , could you please review this PR? Thank you in advance :) |
Member
|
Hi @dmitry-kandiner thanks for all the work. Will have a look in a couple of hours. Sorry for the delay |
Author
|
Thanks alot, no problem |
Author
|
@xfischer Is there any chance this PR will be merged? Are there any plans for next release? Thank you in advance. |
Signed-off-by: Dmitry Kandiner <dmitry.kandiner@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Id field of the Feature object to accept both string and numeric values.