RDF Subclassing feature #400
Merged
+308
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully for the last time
achilleas-k
approved these changes
Jul 15, 2020
Member
achilleas-k
left a comment
There was a problem hiding this comment.
Looks good. One tiny recommendation.
In homage to the unknown DAU all whitespaces are excluded from the custom RDF subclasses dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes issue #397 and its sub-issues #394, #395 and #396.
RDF subclasses are now properly added by default to any written RDF document. The RDF document will now also include RDF Subclass definitions in addition to the actual data (see issue #396) to enable Subclass specific queries.
rdf_subclassattribute, to disable subclassing (see issue Make RDF subclassing optional #394).custom_subclassesattribute to provide additional subclass mappings in addition to the default one (see issue Custom RDF subclassing #395).