Fix VersionConverter encoding issue #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achilleas-k
approved these changes
Jul 24, 2018
Closes G-Node#295 When reading a single string value from csv which is containing commata, make sure, that it still remains a single string value and is not split up into a multi value at the comma positions.
When writing multiple values to csv make sure that whitespaces and carriage return linefeeds as well as quotation marks that have been added by the csv writer are removed before returning the csv string.
jgrewe
reviewed
Jul 25, 2018
| # is part of the value and must not be used to | ||
| # split up the string. | ||
| return [value_string] | ||
|
|
Contributor
Author
There was a problem hiding this comment.
@JuliaSprenger caught that one, I'm just taking it one step further. ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further, any leading or trailing whitespaces are removed from any string values when it is written to
csv. Along the same lines, multiple values that are saved to file via the
version_converterdo not contain leading whitespaces any longer.