Removed support for older Doctrine versions #1612
Conversation
6cfaada to
7e5fb85
Compare
|
👍 |
1 similar comment
|
👍 |
7e5fb85 to
47d6906
Compare
The minimal versions are now Doctrine Common 2.3, Doctrine ORM 2.4 and Doctrine MongoDB ODM 1.0-alpha10.
It duplicates the logic rather than extending the class to allow having clean typehints in the future-proof class.
f8b69f9 to
d3fc0f8
Compare
This PR was merged into the 2.0.x-dev branch. Discussion ---------- Removed support for older Doctrine versions The minimal versions are now Doctrine Common 2.3, Doctrine ORM 2.4 and Doctrine MongoDB ODM 1.0-alpha10. I just figured out that CouchDB does not yet rely on the Doctrine Common events yet, so I will need to change this partially (I was in the train when doing it, without access to github to check it). I'm wondering whether I revert the removal of the CouchDB dedicated listener, or whether I update the ODM and try to convince @beberlei to release a new version instead. I don't know how many people use the CouchDB integration in the bundle. Commits ------- d3fc0f8 Re-added a dedicated listener for CouchDB 910b668 Removed support for older Doctrine versions
|
I'm not sure if it's just my weird setup in an older project, but the compiler is removing the fos_user.doctrine_registry alias even though it is being used by the ORM fos_user.object_manager service. app/cache/de_/ap_DevDebugProjectContainerCompiler.log after a composer upgrade and a failed cache:clear: Symfony\Component\DependencyInjection\Compiler\RemovePrivateAliasesPass: Removed service "fos_user.doctrine_registry"; reason: private alias The service definition in app/cache/de_/ap_DevDebugProjectContainer.xml: |
|
@merk this may be a bug in Symfony failing to detect that a factory is using the service (or failing to inline the factory itself) |
|
I'm planning another change (hopefully for tomorrow evening but I cannot guarantee it) where I would inject the registry rather than the manager, which would keep the ORM lazy and would also be compatible with resetting the entity manager. This would remove this pattern here (but it would still be good to identify a bug in Symfony) |
|
see symfony/symfony#17554 for the fix in Symfony |
The minimal versions are now Doctrine Common 2.3, Doctrine ORM 2.4 and Doctrine MongoDB ODM 1.0-alpha10.
I just figured out that CouchDB does not yet rely on the Doctrine Common events yet, so I will need to change this partially (I was in the train when doing it, without access to github to check it).
I'm wondering whether I revert the removal of the CouchDB dedicated listener, or whether I update the ODM and try to convince @beberlei to release a new version instead. I don't know how many people use the CouchDB integration in the bundle.