[WIP] Added priority to form type extension for compatibility with Symfony 3.2 #1630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, it looks good to me. Could you add a failing test to avoid future regressions? |
|
@daFish actually, it looks like this is a bug in symfony due to an unpredictable behavior of |
|
symfony/symfony#20995 has been merged. |
|
Thanks @daFish ! |
|
Great to see the root source of the issue has been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1602 by introducing a priority for the form extension type.
Can someone with a Symfony version < 3.2 test this change to see if it working without any problems?