Make CI useful again and add type declarations #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit:
- Adds type declarations to bring down the PHPStan error count
- Makes the CI not dependant on a PHPStan pass so that it can run
through to the unit tests
- Upgrades the dev dependanies so that they can install on a modern
system (i.e. without ext-mongo)
- Disables the Propel tests
- Updates the PHPStan configuration file
|
@GKFX really nice, but could you split this PR in to smaller ones, please. |
This was referenced Oct 6, 2020
GKFX
added a commit
to GKFX/FOSOAuthServerBundle
that referenced
this pull request
Oct 6, 2020
GKFX
added a commit
to GKFX/FOSOAuthServerBundle
that referenced
this pull request
Oct 6, 2020
GKFX
added a commit
to GKFX/FOSOAuthServerBundle
that referenced
this pull request
Oct 8, 2020
This commit is dependant on FriendsOfSymfony#663 or FriendsOfSymfony#666 to upgrade the PHPUnit dependency to ^8. It brings the tests to a passing state by removing all deprecation warnings that are within this project's control.
GKFX
added a commit
to GKFX/FOSOAuthServerBundle
that referenced
this pull request
Oct 8, 2020
This commit is dependant on FriendsOfSymfony#663 or FriendsOfSymfony#666 to upgrade the PHPUnit dependency to ^8. It brings the tests to a passing state by removing all deprecation warnings that are within this project's control.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request:
composer installcan run withoutext-mongo. This could be removed again if doctrine/mongodb-odm is upgraded, as in the elchris fork.FOS\OAuthServerBundle\Propel\omnamespaceThe first commit is unfortunately rather large. A lot of it comes from running
sedoverTests/to add return type declarations, which inevitably produced a lot of changes.