Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

feat: + tree command #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 21, 2024
Merged

feat: + tree command #985

merged 6 commits into from
Mar 21, 2024

Conversation

iorisa
Copy link
Collaborator

@iorisa iorisa commented Mar 11, 2024

Features
Implement the same functionality as the tree command.
Example:

        root
        +-- dir1
        |   +-- file1.txt
        |   +-- file2.txt
        +-- dir2
        |   +-- subdir1
        |   |   +-- file1.txt
        |   |   +-- file2.txt
        |   +-- subdir2
        |       +-- file1.txt
        |       +-- file2.txt
        +-- file.txt

geekan
geekan reviewed Mar 11, 2024
View reviewed changes
metagpt/utils/tree.py Outdated Show resolved Hide resolved
metagpt/utils/tree.py Outdated Show resolved Hide resolved
metagpt/utils/tree.py Outdated Show resolved Hide resolved
@geekan
Copy link
Collaborator

geekan commented Mar 11, 2024

I still want to ask a question: now that the tree command exists and it provides a large number of options, why should we reimplement it? What are the benefits?

@iorisa iorisa requested a review from geekan March 12, 2024 03:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.85714% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.59%. Comparing base (bbb9645) to head (9cfcfb1).
Report is 231 commits behind head on main.

Files Patch % Lines
metagpt/utils/tree.py 92.85% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #985      +/-   ##
==========================================
- Coverage   82.71%   82.59%   -0.13%     
==========================================
  Files         227      228       +1     
  Lines       13196    13252      +56     
==========================================
+ Hits        10915    10945      +30     
- Misses       2281     2307      +26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@geekan geekan merged commit 5ee95b1 into FoundationAgents:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekan geekan geekan approved these changes

Assignees

No one assigned

Labels

features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iorisa @geekan @codecov-commenter
Morty Proxy This is a proxified and sanitized view of the page, visit original site.