Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update code plan and change and Improve test coverage #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 5, 2024
Merged

Update code plan and change and Improve test coverage #948

merged 8 commits into from
Mar 5, 2024

Conversation

mannaandpoem
Copy link
Contributor

Features

  1. Split CODE_PLAN_AND_CHANGE into DEVELOPMENT_PLAN and IMPLEMENT_CHANGE and update prompt
  2. Update zip files to maintain consistency with TASK_PDF_FILE_REPO of const.py
  3. Adjust the position of the log for WriteCodePlanAndChange
  4. Improve test coverage

@codecov-commenter
Copy link

codecov-commenter commented Feb 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (a204d99) to head (1c7f638).
Report is 25 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #948      +/-   ##
==========================================
+ Coverage   81.52%   82.18%   +0.66%     
==========================================
  Files         228      228              
  Lines       12679    12667      -12     
==========================================
+ Hits        10336    10410      +74     
+ Misses       2343     2257      -86

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

geekan
geekan requested changes Feb 29, 2024
View reviewed changes
metagpt/utils/project_repo.py Outdated Show resolved Hide resolved
tests/metagpt/actions/test_write_prd.py Show resolved Hide resolved
@mannaandpoem
1. Refactor code to centralize unittest directory pattern using a fix…
1c7f638 
…ture in conftest.py

2. Setup incremental workdir for testing in test_write_code.py
geekan
geekan approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geekan geekan merged commit 1e5656d into FoundationAgents:main Mar 5, 2024
@mannaandpoem mannaandpoem deleted the update_plan_and_improve_coverage branch May 29, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekan geekan geekan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mannaandpoem @codecov-commenter @geekan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.