Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

BaoLiqi
Copy link
Contributor

@BaoLiqi BaoLiqi commented Feb 23, 2024

Fix action.llm.model in examples/debate_simple

Features
Assigned configs for actions to prevent action.llm.model being overridden in Role._init_action.

Feature Docs

Influence
The settings for action.llm.model in the example code now work.

Result
2024-02-23 08:52:39.815 | INFO | metagpt.roles.role:_act:399 - Alex(Democratic candidate): to do Action(AlexSay)
Climate change is real, urgent, and demands bold action now! We can't afford to wait.
2024-02-23 08:52:43.782 | INFO | metagpt.utils.cost_manager:update_cost:52 - Total running cost: $0.001 | Max budget: $10.000 | Current cost: $0.001, prompt_tokens: 83, completion_tokens: 20
2024-02-23 08:52:43.785 | INFO | metagpt.roles.role:_act:399 - Bob(Republican candidate): to do Action(BobSay)
Climate change is a pressing issue that demands immediate action. We cannot afford to delay any longer.
2024-02-23 08:52:45.168 | INFO | metagpt.utils.cost_manager:update_cost:52 - Total running cost: $0.000 | Max budget: $10.000 | Current cost: $0.000, prompt_tokens: 95, completion_tokens: 19

Other
Referenced test_context_mixin/test_config_priority().

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (06d7269) to head (cdd3025).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage   81.19%   81.19%           
=======================================
  Files         226      226           
  Lines       12477    12477           
=======================================
  Hits        10131    10131           
  Misses       2346     2346           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@geekan geekan merged commit 5713526 into FoundationAgents:main Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.