Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Feat rag add more features #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 27, 2024
Merged

Feat rag add more features #1114

merged 13 commits into from
Mar 27, 2024

Conversation

better629
Copy link
Member

@better629 better629 commented Mar 27, 2024 •
edited
Loading

Features

  • rag add engine like es
  • rag add rerank like flare, object-rerank-by-field-val, colbert

Feature Docs

Influence

Result

========================================================================================================= test session starts ==========================================================================================================
collected 29 items                                                                                                                                                                                                                     

tests/metagpt/rag/engines/test_simple.py .....                                                                                                                                                                                   [ 17%]
tests/metagpt/rag/factories/test_base.py ..........                                                                                                                                                                              [ 51%]
tests/metagpt/rag/factories/test_ranker.py .....                                                                                                                                                                                 [ 68%]
tests/metagpt/rag/factories/test_retriever.py ......                                                                                                                                                                             [ 89%]
tests/metagpt/rag/retrievers/test_bm25_retriever.py .                                                                                                                                                                            [ 93%]
tests/metagpt/rag/retrievers/test_faiss_retriever.py .                                                                                                                                                                           [ 96%]
tests/metagpt/rag/retrievers/test_hybrid_retriever.py .                                                                                                                                                                          [100%]

=========================================================================================================== warnings summary ===========================================================================================================
=================================================================================================== 29 passed, 7 warnings in 10.90s ====================================================================================================

Other

@better629 better629 changed the title Feat rag add more feature Feat rag add more features Mar 27, 2024
geekan
geekan reviewed Mar 27, 2024
View reviewed changes
examples/rag_pipeline.py Outdated Show resolved Hide resolved
examples/rag_pipeline.py Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.69231% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 81.33%. Comparing base (6434503) to head (90e1b62).

Files Patch % Lines
metagpt/rag/factories/index.py 43.75% 9 Missing ⚠️
metagpt/rag/factories/retriever.py 57.14% 3 Missing ⚠️
metagpt/rag/rankers/object_ranker.py 90.32% 3 Missing ⚠️
metagpt/rag/factories/ranker.py 71.42% 2 Missing ⚠️
metagpt/rag/retrievers/es_retriever.py 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1114      +/-   ##
==========================================
+ Coverage   81.28%   81.33%   +0.04%     
==========================================
  Files         248      251       +3     
  Lines       13895    13980      +85     
==========================================
+ Hits        11294    11370      +76     
- Misses       2601     2610       +9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

geekan
geekan approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@geekan geekan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geekan geekan merged commit 6450a09 into FoundationAgents:main Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geekan geekan geekan approved these changes

+1 more reviewer

@seehi seehi seehi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@better629 @codecov-commenter @geekan @seehi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.