Fix permissions error #298 and improve permissions in general #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d46278e to
dccfba2
Compare
|
Thanks for the PR. Wouldn't that remove the executable bit from /app/gokapi? |
|
From: git checkout fix-298-permissions-error
docker build -t foo .
docker run --rm --name foo -d foo
docker exec -it foo /bin/ls -la /appI see So |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up permission in
dockerentry.shin 3 ways:dockerentry.shchmod +x's all files inconfig. #298 bychmod-ing directories to 750, then effectivelychmod-ing files to 640, but without removing any existing executable (x) permissions. I.e. executables will remain executables (to user and group)DOCKER_NONROOTis set. This is both for consistency but also ensures consistency should a user tryDOCKER_NONROOTthen revertchownwhenDOCKER_NONROOTis not set; this is in case a user switches from usingDOCKER_NONROOTthen back.