Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
Discussion options

Thank you guys for your ongoing effort to develop FluidSynth.

I've noticed that in #1469, #1494 and #1620 some core files were converted from C to C++. While I understand the technical benefits C++ can offer, this change unfortunately prevents the Wine project from updating to newer versions of FluidSynth, as Wine does not accept C++ code. I've also identified a potential license compatibility issue with the new GCEM depencency (#1681).

I wanted to ask if switching these specific components back to C is a possibility you would consider? Wine only uses the core synth/DSP functionality, so it would be perfectly fine for the other parts (like the C++11 OSAL or DLS parser) to remain in C++.

I'm prepared to do the work to port the necessary components to C. Would you be open to reviewing such a pull request?

Thanks for your time and consideration.

You must be logged in to vote

Replies: 1 comment · 1 reply

Comment options

I wanted to ask if switching these specific components back to C is a possibility you would consider?

No. Sry. Maintaining C becomes more and more a pain, compared to the functionality offered by modern languages like C++. Whenever I'll write new code, it will be written in C++11 now. Just like when I believe that existing code would benefit from C++, it will be ported to C++.

Also, given that fluidsynth runs natively on (all?) POSIX platforms, I consider support for Wine as out of scope.

You must be logged in to vote
1 reply
@baskanov
Comment options

OK, I understand. Thanks for clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.