Add Catalan language and update Spanish language #2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @deividgp thanks for this. The tests are currently failing as the new language hasn't been added to the LanguageManager. Please could you add it in there too? See here for how the existing languages are configured Thanks! |
|
oops, did not notice that file. It should work now @JeremySkinner . |
|
Merged, thanks! |
|
I believe the intended Spanish translation fix is incorrect. The plural for "carácter" is "caracteres", without a tilde. ref: RAE article RAE, or Real Academia Española (Royal Spanish Academy) is the oficial Spanish language institution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.