Add file name suffix option #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows appending a custom suffix to generated file names before the extension. For example, if the suffix is `.g`, the generated client file name would be `moduleName.g.js` (or `moduleName.g.ts` when using TypeScript).
Contributor
|
It's fine by me! It's been a while, but I think I imagined that it would uglify imports.
would have to be
or
presumably? Or maybe everything has changed again and |
Contributor
Author
|
I hadn't considered that, but I think you're right. Usually we add an librarySearchApi/index.ts Usage |
ejball
approved these changes
May 17, 2024
# Conflicts: # src/fsdgenjs/FsdGenJavaScriptApp.cs
ejball
reviewed
May 17, 2024
| var service = parser.ParseDefinition(new ServiceDefinitionText("TestApi.fsd", definition)); | ||
| var generator = new JavaScriptGenerator { GeneratorName = "JavaScriptGeneratorTests", TypeScript = isTypeScript, Express = true, FileNameSuffix = suffix }; | ||
| var result = generator.GenerateOutput(service); | ||
| Assert.IsNotNull(result); |
Contributor
There was a problem hiding this comment.
NUnit 4 does asserts differently; see above for examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows appending a custom suffix to generated file names before the extension. For example, if the suffix is
.g, the generated client file name would bemoduleName.g.js(ormoduleName.g.tswhen using TypeScript).We want to use
.gto make it easier to identify these as auto-generated files, specifically in.gitattributeswithout explicitly listing each file. This is a very minor inconvenience, so we're not hard pressed to find a solution. If adding a suffix option here isn't a good idea, just let me know.