Add support for Fastify server plugins. #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preparing to add fastify server impl.
Codegen is incoming!
And generate conformance plugin.
- all but three conformance tests are passing (mirrorBytes, mirrorText, and bodyTypes) which will require a bit of work to configurare the fastify server, as well as potential changes to the generated client, which assumes that fetch requests come back with JSON.
- This allows the plugin to live anywhere without needing to know where the client type file is. I debated creating a new type file instead of inlining them in the plugin, but didn't really see a point since it is just for the server to use. Perhaps I'm missing something though...
No longer needed!
- This allows the plugin to live wherever the user wants it to live. - Ideally I would think the express server should be generated the same way but that would be a breaking change, so maybe not needed?
As well, we are now running all conformance tests together, testing all client and server code.
Contributor
Author
|
@ejball wanted to make sure this doesn't fall off your radar. |
Contributor
That sounds right, aka #9. |
ejball
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also gets conformance tests up and running. I chose not to create an Express conformance server, but I would think it would be pretty trivial.
Conformance test methods NOT passing for the generated fastify plugin:
mirrorBytesmirrorTextbodyTypesI think the failures are due to the generated client not supporting a string body in the http response. It may be an issue with configuring the fastify server as well, I didn't look too closely into yet.
I also wasn't sure how to generate the C# documentation using
XmlDocGen.