Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@heymb
Copy link
Contributor

@heymb heymb commented Sep 15, 2023

No description provided.

@ejball
Copy link
Contributor

ejball commented Sep 15, 2023

Per CONTRIBUTING, you'll need to run build.ps1 codegen and commit the changes.

example/ts/src/exampleApiServer.ts Show resolved Hide resolved
@heymb heymb requested a review from ejball September 18, 2023 14:25
Copy link
Contributor

@ejball ejball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Feel free to merge, bump the version, and publish.

example/ts/src/exampleApiServer.ts Show resolved Hide resolved
@heymb
Copy link
Contributor Author

heymb commented Sep 18, 2023

merge, bump the version, and publish

I see notes on releasing in the contributing doc, but just want to confirm this should be a minor bump like this commit

example/ts/src/exampleApiServer.ts Show resolved Hide resolved
src/Facility.CodeGen.JavaScript/JavaScriptGenerator.cs Outdated Show resolved Hide resolved
@ejball
Copy link
Contributor

ejball commented Sep 18, 2023

A minor bump is fine.

@heymb heymb merged commit d96d6f5 into FacilityApi:master Sep 18, 2023
@heymb
Copy link
Contributor Author

heymb commented Sep 18, 2023

@heymb heymb deleted the generateErrorSets branch September 18, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.