Standard error codes should use PascalCase. #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Are |
Contributor
Author
|
I noticed the test error locally, but figured a PR was the easiest way to inquire about it. |
@types/node version wasn't specified, and newer versions have a more return complicated type for http.Server.address(). This fixes an error building the tests. 6 and 8 are both currently maintenance LTS, but 6 is about to be EOL. package-lock.json was generated from npm 6.8.0.
ddunkin
reviewed
Feb 18, 2019
Contributor
ddunkin
left a comment
There was a problem hiding this comment.
Should this be on the v1 branch? It is a breaking change, right?
Yes, package-lock.json should be committed.
Contributor
Author
|
It's a breaking bug fix, so I wondered if I should make it available to v1 users. But I suppose we could only make it available to v2 users. |
Contributor
Author
|
Thanks for figuring out the issue. |
ddunkin
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard error codes have always been PascalCase, but I somehow failed to remember that when I initially wrote this code.