Feature/network first option#25
Feature/network first option#25mpatafio wants to merge 10 commits intoExilz:masterExilz/apipeline:masterfrom mpatafio:feature/network_first_optionmpatafio/apipeline:feature/network_first_optionCopy head branch name to clipboard
Conversation
|
Hi, This is something I thought about adding, too. Could you make sure not to commit your |
|
Removed idea files 👍 thanks |
|
Hi @Exilz, I've removed the stuff you suggested, then updated the Readme and bumped the minor version. The PR is ready to be merged if you want. |
|
@Exilz up! |
|
@Exilz up please) |
|
@Exilz up pleasssseeeeeeeee!!! |
|
don't leave uuuus XD @Exilz |
|
@Exilz merge pls |
|
Thanks for the code review @Villar74 . I added some comments, too. Once you've made the requested changes, let's squash your commits before merging them. |
|
@Villar74 yes 😄 |
|
Hi guys! Thank you for the comments! I’ll fix them as soon as I’ll come back from holiday (likely 21st of August) |
|
Hi guys! Thank you for the code review, I've resolved all the comments (apart the generated js files). Now I guess it can be merged. Just one thing for @Exilz: the image showing the flow of the library should be changed according to this new flow (conditioned by network first option), I changed the documentation, cannot do the same for such image. Thank you! |
|
@Exilz up |
|
are you still there guys? |
|
@Exilz wake up pls, bro) |
|
@Exilz Maxime, merge pls |
Hi @Exilz !
you lib is great!
I was trying to manage a real use case in the mobile world (and not only in it I guess): make a request perform a
network firstoperation rather than check cache availability at the beginning of the flow. This will allow clients to try to refresh cache without altering the service definition, also because it wasn't possibile by defining any kind ofmiddleware. This way clients are able to use the same service (then same cache) and by customising service options they can make the request behave accordingly to the above need.Hope it makes sense.
Regards