Use "services" in GitHub actions #1207
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the GitHub Actions workflow configuration by replacing third-party container actions with GitHub's native containerized services for PostgreSQL and Redis. The motivation is to avoid Docker Hub rate limiting issues that caused recent CI failures.
- Migrated PostgreSQL from
harmon758/postgresql-action@v1to native GitHub services - Migrated Redis from
supercharge/redis-github-action@1.5.0to native GitHub services - Standardized Redis port from 6456 to 6379 in the test workflow
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/test.yml |
Replaced custom Postgres and Redis actions with native GitHub services; updated Redis port from 6456 to 6379; added health checks for both services |
.github/workflows/deployment-checks.yml |
Replaced custom Postgres action with native GitHub services; added Redis service with health checks |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| POSTGRES_DB: ${{ env.DB_NAME }} | ||
| POSTGRES_USER: ${{ env.DB_USER }} | ||
| POSTGRES_PASSWORD: ${{ env.DB_PASSWORD }} |
There was a problem hiding this comment.
The env context is not available in the services section of GitHub Actions. The expressions ${{ env.DB_NAME }}, ${{ env.DB_USER }}, and ${{ env.DB_PASSWORD }} will not be interpolated and will result in empty values being passed to the PostgreSQL container.
You should use hardcoded values directly in the service configuration instead.
| POSTGRES_DB: ${{ env.DB_NAME }} | |
| POSTGRES_USER: ${{ env.DB_USER }} | |
| POSTGRES_PASSWORD: ${{ env.DB_PASSWORD }} | |
| POSTGRES_DB: tess | |
| POSTGRES_USER: tess | |
| POSTGRES_PASSWORD: password |
There was a problem hiding this comment.
This does not seem to be the case, as indicated by the actions running successfully.
| POSTGRES_DB: ${{ env.DB_NAME }} | ||
| POSTGRES_USER: ${{ env.DB_USER }} | ||
| POSTGRES_PASSWORD: ${{ env.DB_PASSWORD }} |
There was a problem hiding this comment.
The env context is not available in the services section of GitHub Actions. The expressions ${{ env.DB_NAME }}, ${{ env.DB_USER }}, and ${{ env.DB_PASSWORD }} will not be interpolated and will result in empty values being passed to the PostgreSQL container.
You should use hardcoded values directly in the service configuration instead.
| POSTGRES_DB: ${{ env.DB_NAME }} | |
| POSTGRES_USER: ${{ env.DB_USER }} | |
| POSTGRES_PASSWORD: ${{ env.DB_PASSWORD }} | |
| POSTGRES_DB: tess | |
| POSTGRES_USER: tess | |
| POSTGRES_PASSWORD: password |
Summary of changes
Motivation and context
Action run failed due to rate limit hit: https://github.com/ElixirTeSS/TeSS/actions/runs/20440274417/job/58731372004#step:5:18
and possibly GitHub does some caching/mirroring when you use its built-in services that could avoid this...?
Checklist
to license it to the TeSS codebase under the
BSD license.