Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit c4fc79a

Browse filesBrowse files
committed
Remove outdated git_daemon_launched Windows info
This removes the Windows-specific information in the warning message in git_daemon_launched. After the associated functionality was updated in gitpython-developers#1684 and the warning message was abridged accordingly, the functionality was updated again in gitpython-developers#1697, causing the message to be outdated and no longer helpeful (since having git-daemon.exe in a PATH directory is no longer necessary or useful), without any corresponding change to the message.
1 parent cc0e0d9 commit c4fc79a
Copy full SHA for c4fc79a

File tree

1 file changed

+0
-8
lines changed
Filter options

1 file changed

+0
-8
lines changed

‎test/lib/helper.py

Copy file name to clipboardExpand all lines: test/lib/helper.py
-8Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -213,14 +213,6 @@ def git_daemon_launched(base_path, ip, port):
213213
and setting the environment variable GIT_PYTHON_TEST_GIT_DAEMON_PORT to <port>
214214
"""
215215
)
216-
if is_win:
217-
msg += textwrap.dedent(
218-
R"""
219-
220-
On Windows,
221-
the `git-daemon.exe` must be in PATH.
222-
For MINGW, look into \Git\mingw64\libexec\git-core\, but problems with paths might appear."""
223-
)
224216
log.warning(msg, ex, ip, port, base_path, base_path, exc_info=1)
225217

226218
yield # OK, assume daemon started manually.

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.