So previously when generating cln-rpc's model.rs we would just count from 0 upwards for enum fields and it somehow worked until i start removing fields and want to preserve backward compatibility. Now i added a commit where we lookup .msggen.json for the field numbers for model.rs whenever we can find them. If not we go back to simple counting. Happy to hear your feedback.

this also found another wrong assigment in GetinfoBindingType btw

Yeah, we haven't removed fields so far, hence we never had a confirmation it'd be assigning stable field numbers. It seems you are hitting a couple of new and untested scenarios. Apologies for not having tried some of these before, and thanks for the incredible help 🙏

had to add another check for an edge case that would cause problems in #7218

added explicit numbering of rust enums

rebased and fixed

I think I found one place where we are still just iterating numbers rather than picking them from the .mssggen.json file in grpc.py, otherwise this is very much good to go 👍

Where in grpc.py? enums for node.proto get sorted. For convert.rs sorting should be irrelevant, right?

I think I found one place where we are still just iterating numbers rather than picking them from the .mssggen.json file in grpc.py, otherwise this is very much good to go 👍

Where in grpc.py? enums for node.proto get sorted. For convert.rs sorting should be irrelevant, right?

I meant the 1 that should be a 3 in the previous comment :-)