Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update lnprototest with the last version of master#4517

Merged
rustyrussell merged 2 commits intoElementsProject:masterElementsProject/lightning:masterfrom
vincenzopalazzo:vincenzopalazzp/lnprototest_versionvincenzopalazzo/lightning:vincenzopalazzp/lnprototest_versionCopy head branch name to clipboard
Jun 25, 2021
Merged

Update lnprototest with the last version of master#4517
rustyrussell merged 2 commits intoElementsProject:masterElementsProject/lightning:masterfrom
vincenzopalazzo:vincenzopalazzp/lnprototest_versionvincenzopalazzo/lightning:vincenzopalazzp/lnprototest_versionCopy head branch name to clipboard

Conversation

@vincenzopalazzo
Copy link
Collaborator

@vincenzopalazzo vincenzopalazzo commented May 8, 2021

I followed the last update of lnprototest and I hope to avoid mistakes with this PR.
The actual version of lnprototest is a couple of comments back, and it missing the update with bitcoin 0.21.0 made by this PR rustyrussell/lnprototest#10.

I made a double-check, and I think that the previous version of lnprototest is fully contained inside the master, with the following PR rustyrussell/lnprototest#5.

Correct me if I'm wrong @niftynei 😄

let see what GitHub action react to this change💺

Closing #4516

@rustyrussell rustyrussell requested a review from niftynei May 12, 2021 06:42
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch from 2e76973 to 37bf2e1 Compare May 17, 2021 21:57
@vincenzopalazzo
Copy link
Collaborator Author

vincenzopalazzo commented May 17, 2021 •
edited by rustyrussell
Loading

Fixed #4516

For the actual condition of the lightning unit test only the change inside the lnprototest is required to fix the problem with bitcoin, this is a test that I made with my forks https://github.com/vincenzopalazzo/lightning/runs/2549511882

All stuff is done from my side.

Ping @niftynei only for information.

@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch 3 times, most recently from ffd2dde to e42f5e2 Compare May 25, 2021 10:05
@cdecker cdecker force-pushed the vincenzopalazzp/lnprototest_version branch from e42f5e2 to 1764d9a Compare May 25, 2021 14:31
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch 3 times, most recently from aec01a9 to abfbd1c Compare May 30, 2021 13:10
@niftynei
Copy link
Collaborator

niftynei commented Jun 1, 2021

There's a problem with the wallet configuration in master.

E               bitcoin.rpc.JSONRPCError: {'code': -19, 'message': 'Wallet file not specified (must request wallet RPC through /wallet/<filename> uri-path).'}

Does this PR need to be merged first? https://github.com/rustyrussell/lnprototest/pull/12/files

@niftynei
Copy link
Collaborator

niftynei commented Jun 1, 2021

Oh I see I missed your comment about how #12 is necessary. Ok.

@niftynei
Copy link
Collaborator

niftynei commented Jun 1, 2021

Concept ACK, but we're not ready yet on the lnprototest side.

@vincenzopalazzo
Copy link
Collaborator Author

vincenzopalazzo commented Jun 1, 2021 •
edited
Loading

Concept ACK, but we're not ready yet on the lnprototest side.

Yes, When the PR is in the master (lnprototest master) we can have the GitHub action happy again :-)

@rustyrussell
Copy link
Contributor

rustyrussell commented Jun 17, 2021

OK, I'm merging the lnprototest fixes today, and then I can rebase this and the World Will Be Amazing! (Again)!

Thanks @vincenzopalazzo! I've given you commit access to the lnprototest repo too, so you don't have to wait for me next time!

@rustyrussell rustyrussell force-pushed the vincenzopalazzp/lnprototest_version branch from abfbd1c to d5dd480 Compare June 17, 2021 04:18
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch from d5dd480 to 3a8a56d Compare June 17, 2021 09:14
@vincenzopalazzo
Copy link
Collaborator Author

vincenzopalazzo commented Jun 17, 2021 •
edited
Loading

I've given you commit access to the lnprototest repo too, so you don't have to wait for me next time!

Thanks, Rusty 😸

OK, I'm merging the lnprototest fixes today, and then I can rebase this and the World Will Be Amazing! (Again)!

Rebased on top of the master, let see what GitHub action will says 💺

@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch from 3a8a56d to f2f1eb4 Compare June 23, 2021 11:05
@vincenzopalazzo
Update lnprototest submodule
2f7cb60 
This is a fix propose of the ticket ElementsProject#4516

Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch from f2f1eb4 to 6f4c14d Compare June 24, 2021 19:05
@vincenzopalazzo
Update at latest version of lnprototest with the support of channel_type
dce6e52 
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
@vincenzopalazzo vincenzopalazzo force-pushed the vincenzopalazzp/lnprototest_version branch from 6f4c14d to dce6e52 Compare June 24, 2021 21:23
@rustyrussell
Copy link
Contributor

rustyrussell commented Jun 25, 2021

Ack dce6e52

@rustyrussell rustyrussell merged commit 8d146ea into ElementsProject:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niftynei niftynei Awaiting requested review from niftynei

Assignees

@niftynei niftynei

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vincenzopalazzo @niftynei @rustyrussell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.