Allocate own string for invoice description#1020
Closed
ZmnSCPxj wants to merge 2 commits intoElementsProject:masterElementsProject/lightning:masterfrom
ZmnSCPxj:long-invoice-descriptionZmnSCPxj/lightning:long-invoice-descriptionCopy head branch name to clipboard
Closed
Allocate own string for invoice description#1020ZmnSCPxj wants to merge 2 commits intoElementsProject:masterElementsProject/lightning:masterfrom ZmnSCPxj:long-invoice-descriptionZmnSCPxj/lightning:long-invoice-descriptionCopy head branch name to clipboard
ZmnSCPxj wants to merge 2 commits intoElementsProject:masterElementsProject/lightning:masterfrom
ZmnSCPxj:long-invoice-descriptionZmnSCPxj/lightning:long-invoice-descriptionCopy head branch name to clipboard
Conversation
Fixes: ElementsProject#1014 If `b11->description_hash` is set, then `b11->description` is NULL. So, we must allocate the description string separately.
rustyrussell
requested changes
Feb 17, 2018
Contributor
rustyrussell
left a comment
There was a problem hiding this comment.
Unfortunately we need to simply fail for now, if description is too long. There's no way to transport the description, and it's a requirement; the hash code is really for alternate transports, and I was overzealous to ever implement it in c-lightning :(
Contributor
Author
|
Okay, will close this request and reopen a new one instead. |
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this pull request
Feb 17, 2018
ZmnSCPxj
added a commit
to ZmnSCPxj/lightning
that referenced
this pull request
Feb 17, 2018
rustyrussell
pushed a commit
that referenced
this pull request
Feb 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent segfault when long invoice description is generated.
Fixes: #1014